Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: Support use different color to indicate move blunder in variation #413

Merged
merged 2 commits into from
Nov 8, 2018

Conversation

zsalch
Copy link
Contributor

@zsalch zsalch commented Oct 31, 2018

Base on #412
Closes #389

Color node:
image

With comment node:
image

  1. Config:
    "blunder-winrate-thresholds": [-30,-20,-10,-5,5,10],
    "blunder-node-colors":[[255,0,0],[0,255,0],[0,0,255],[255,255,0],[0,255,255],[255,0,255]],
    "comment-node-color":[0,0,255,255],

  2. Ctrl+T for toggle the node color with the comment

  3. Press ‘Y' for switch node color display

    default (show color) -> only black color -> only white color

@featurecat
Copy link
Owner

LGTM

@featurecat featurecat merged commit 94c5a96 into featurecat:next Nov 8, 2018
@featurecat
Copy link
Owner

By the way, you forgot to add the three config values to the config file. So I had to add them to get it to work. I fixed it. You should try deleting the config file as a test before making a PR, to see if a new feature still works.

@featurecat
Copy link
Owner

Actually apparently the node color is part of the theme. I'm not sure how I got it to work but it no longer works as of now. It's not part of the default theme which is problematic.

@zsalch
Copy link
Contributor Author

zsalch commented Nov 8, 2018

You are right. Only these three options have no default value. I missed them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants