Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong method name in context.method #60

Closed
mikeconley12 opened this issue Nov 4, 2020 · 6 comments
Closed

Wrong method name in context.method #60

mikeconley12 opened this issue Nov 4, 2020 · 6 comments

Comments

@mikeconley12
Copy link

Steps to reproduce

Please use this example. In this example, I called the create() method, but context.method gives me find instead of create.

Expected behavior

I expected to get the following output from the example:

context.method create

Actual behavior

I get the following output from the example:

context.method find

System configuration

Module versions:

@feathersjs/hooks: 0.5.0

NodeJS version: v12.18.3

Operating System: Linux

@bertho-zero
Copy link
Collaborator

I see it on master but it is fixed with #57

@bertho-zero
Copy link
Collaborator

@feathersjs/hooks directly modify your middleware array:

  1. this._middleware = middleware;

  2. manager._middleware.unshift(properties({ method }));

@mikeconley12
Copy link
Author

I see it on master but it is fixed with #57

Good, so it would be great if #57 was merged.

@daffl
Copy link
Member

daffl commented Nov 8, 2020

Closed now via #57

@daffl daffl closed this as completed Nov 8, 2020
@mikeconley12
Copy link
Author

Thanks!

@mikeconley12
Copy link
Author

@daffl could you please tell me when you plan to publish this fix to NPM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants