Revert pull request #37

[bertho-zero]

No description provided.

[bertho-zero]

Hi @daffl, as discussed in #37 (comment) I have put the params/props management back in the HookManager while keeping the fixes made since.

I still have to add the options and see some easy performance improvements.

[bertho-zero]

I just set the defaults of props and params to null rather than an empty array/object, and then avoid unnecessary concat and assign calls.

I added a log in the benchmark tests before/after these changes:

Before:

Runtime: 13
Runtime: 127
Runtime: 149
Runtime: 235

After:

Runtime: 13
Runtime: 89 (-30%)
Runtime: 97 (-35%)
Runtime: 172 (-27%)

[daffl]

Great, thank you, I've been meaning to do this for a while. I'll have a look at it this weekend 😄

[bertho-zero]

I just added a test with middleware options: https://github.com/feathersjs/hooks/pull/57/files#diff-e331ea4ca89b251f010772fe725aa7249277dbc6d472a1fe408a44f7eedbf1abR202-R218

[daffl]

Great, thank you for doing that. Also, really nice to see the performance improvements.