fix: conserve props from original method (#19)

feathersjs · Feb 14, 2020 · 9a77e81 · 9a77e81
1 parent df1f7ff
commit 9a77e81
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/packages/hooks/src/function.ts b/packages/hooks/src/function.ts
@@ -68,5 +68,16 @@ export const functionHooks = <F, T = any>(original: F, opts: HookSettings<T>) =>
   registerContextUpdater(wrapper, updateContext);
   registerMiddleware(wrapper, middleware);
 
+  const originalProps = (Object.keys(original) as any)
+    .concat(Object.getOwnPropertySymbols(original));
+
+  for (const prop of originalProps) {
+    const propDescriptor = Object.getOwnPropertyDescriptor(original, prop);
+
+    if (!wrapper.hasOwnProperty(prop)) {
+      Object.defineProperty(wrapper, prop, propDescriptor);
+    }
+  }
+
   return Object.assign(wrapper, { original, collect });
 };
diff --git a/packages/hooks/test/function.test.ts b/packages/hooks/test/function.test.ts
@@ -325,4 +325,22 @@ describe('functionHooks', () => {
     assert.equal(result, 'Hi Bertho!');
     assert.equal(called, 1);
   });
+
+  it('conserves method properties', async () => {
+    const TEST = Symbol('test');
+    const hello = (name: any) => `Hi ${name}`;
+    (hello as any)[TEST] = true;
+
+    const sayHi = hooks(hello, [
+      async (context, next) => {
+        await next();
+        context.result += '!';
+      }
+    ]);
+
+    const result = await sayHi('Bertho');
+
+    assert.equal(result, 'Hi Bertho!');
+    assert.equal((sayHi as any)[TEST], (hello as any)[TEST]);
+  });
 });