Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Feat/config path from package.json #405

Merged

Conversation

jraut
Copy link
Contributor

@jraut jraut commented Dec 29, 2018

Hello,

This pull request is created because of feathersjs/feathers#987

It lets the CLI use a custom config folder.

Based on the discussions on the issue, the following changes were made to generating a new project

- When creating a project, the package.json is created with a property for a config directory
- The value is read from NODE_CONFIG_DIR env variable since it is used by default
- If the value is not set, it is set to config/ (the current hardcoded value)

Generator uses this new customizable value. It falls back to config/ on run time to maintain backwards compatibility.

@daffl daffl merged commit 5aed867 into feathersjs-ecosystem:master Dec 29, 2018
@daffl
Copy link
Member

daffl commented Dec 29, 2018

I fixed the tests and made the release. Thank you for adding this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants