This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Add models directory for new generators #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DesignByOnyx
force-pushed
the
models-directory
branch
from
01fc2a3
to
8214c19
Compare
daffl
reviewed
Feb 1, 2017
|
|
||
| app.set('sequelizeClient', sequelize); | ||
|
|
||
| app.setup = function(...args) { | ||
| // Set up data relationships |
There was a problem hiding this comment.
I would call const result = oldSetup.apply(this, args); first and then return result; in the end just in case.
|
Just one comment, then I'll merge it in. Thanks again, this is great! |
DesignByOnyx
force-pushed
the
models-directory
branch
from
8214c19
to
9a82946
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #94 for the new generators. This separates models into their own directory and allows sequelize models to set up relationships which are sync'd to the database.