Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

'corsWhitelist' should default to empty array #90

Closed
lukeed opened this issue Mar 22, 2016 · 2 comments
Closed

'corsWhitelist' should default to empty array #90

lukeed opened this issue Mar 22, 2016 · 2 comments

Comments

@lukeed
Copy link

lukeed commented Mar 22, 2016

I picked corsWhitelist in the setup because I wanted to come back to this later.

So, I just pressed enter, sending a blank entry. That entry made its way to here:

/generator-feathers/generators/app/templates/config.default.json:26
    24|     }<% } %>
    25|   }<% } %><% if (cors === 'whitelisted') { %>,
 >> 26|   "corsWhitelist": [<% corsWhitelist.forEach(function(domain, index, list){ %>
    27|     "<%= domain.trim() %>"<% if(index + 1 !== list.length){ %>,<% } %><% }); %>
    28|   ]<% } %>
    29| }

corsWhitelist.forEach is not a function

That value should default to an empty array after exploding the comma-string fails.

@ekryski
Copy link
Member

ekryski commented Mar 22, 2016

This is a duplicate of #85. I think this was closed at the time when you reported this (all good!). We've since re-opened it, so I'll close this one. Thanks for reporting!

@ekryski ekryski closed this as completed Mar 22, 2016
@daffl
Copy link
Member

daffl commented Mar 23, 2016

This is fixed in v0.6.20 of the generator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants