use 'returning: true' for postgres to keep patch and its response atomic #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this only work for Postgres? |
|
Yes.
|
daffl
requested changes
Mar 17, 2017
src/index.js
Outdated
| if (this.dialect === 'postgres') { | ||
| options.returning = true; | ||
| return this.Model.update(omit(data, this.id), options) | ||
| .then((results) => { |
src/index.js
Outdated
| if (id !== null) { | ||
| where[this.id] = id; | ||
| } | ||
|
|
||
| const options = Object.assign({}, params.sequelize, { where }); | ||
|
|
||
| // This is the best way to implement patch in sql, the other dialects 'should' use a transaction. | ||
| if (this.dialect === 'postgres') { |
There was a problem hiding this comment.
I'd check options.Model.sequelize.options.dialect here and remove setting it in the constructor
added 2 commits
March 17, 2017 22:43
daffl
approved these changes
Mar 17, 2017
|
Released as |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR utilizes the Sequelize returning option for update to do PATCH, in a single action.
This is a non-breaking change.
Other Information
The PATCH procedure for the other dialects should probably also be reworked to use transactions, this may only cause problems on large scale deployments, but it is a potential issue.