Fixed missing where clause #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please update immediately, as this breaks current feathers-sequelize if eager-loading is used (luckily quite a new feature anyway). Sry for that :/
daffl
reviewed
Mar 12, 2017
src/index.js
Outdated
| @@ -66,10 +66,12 @@ class Service { | |||
| let promise; | |||
|
|
|||
| if (params.sequelize && params.sequelize.include) { // If eager-loading is used, we need to use the find method | |||
| params.query = params.query || {}; | |||
There was a problem hiding this comment.
We don't want to mutate the object we get passed as the query.
|
Can we add some tests for this feature to make sure everything works as expected? |
|
Unforunately i'm not so confident in writing tests and in this case it would be impossible right? Because you need a database to test against ....... However, one could maybe add a local .sqlite file as a database and test against that. |
|
That is what the existing tests are already doing, would be nice to look into it at one point. Fix released as v1.4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please update immediately, as this breaks current feathers-sequelize if eager-loading is used (luckily quite a new feature anyway). Sry for that :/