Make params optional

[bedeoverend]

Some of the methods e.g. get require params be given (by using params.sequelize). This is fine if dealing with an incoming request or via app.service (I believe) but if using the service directly without going through app it'll throw TypeError: Cannot read property 'sequelize' of undefined

[daffl]

All Feathers service methods run through the normalizer mixin which should set params to an empty object if it doesn't exist.

You do have to make sure to get the service via app.service('servicename')instead of using the service instance directly.

[bedeoverend]

@daffl is that expected behavior? I noticed quite a few other methods in other feathers hooks do a check for params (e.g. params && params.foo). I would expect the ability for it to still work using the service instance directly.

If this isn't expected behavior, or a concern for this plugin, then happy to close, otherwise also happy to do a PR that runs the checks.

[daffl]

You shouldn't use the service instance directly. You won't get hooks or real-time events or anything else that Feathers adds (see here).

The hook checks are probably a relic from pre-normalization times (I think that was < 1.3).

[bedeoverend]

@daffl Ok, thanks for the information. Happy to close this

[daffl]

Thank you for bringing it up. We'll make sure to mention it in more spots in the documentation to make sure it is well known.

[bedeoverend]

@daffl No worries, thanks for the quick responses. My interpretation was that it was best practice to get it via app.service, rather than a necessity. But having said that, and looking back over the docs, the interface of the methods does indicate params as a guaranteed parameter, rather than optional like the callback param: get(id, params[, callback]). As you say though, be great if there is more mention in the docs 😃