Service methods should reject with feathers error instance rather throwing in-place

[rafalszemraj]

https://github.com/feathersjs/feathers-sequelize/blob/master/src/index.js#L61
https://github.com/feathersjs/feathers-sequelize/blob/master/src/index.js#L114

[daffl]

Is there a specific reason for changing this? It should be fine according to the promise spec and I'm fairly sure the tests are covering that those errors are being propagated.

[rafalszemraj]

Maybe I missed something in here (just started with feathers) but what I'm trying to do is to expose my user sequelize service via rest api. I'd expect the have error to be returned as json (same way as I have my results) but instead I get whole stack trace displayed as plain text. Noticed (and checked) that when returning error it gives my nice json output I can consume in my UI. Is there something I need to do to prepare my feather app to be able to catch these exceptions?

[ekryski]

@rafalszemraj If you are using the Feathers error handler in your app (which is included in a generated app) then errors will be returned as JSON. My guess is you don't have the error handler included and it is instead using the default error handler that comes with Express.

See http://docs.feathersjs.com/middleware/error-handling.html for how to configure the feathers error handler.

[rafalszemraj]

@ekryski I'm using feathers error handler, but (and this is what I missed) I did not added it as a last middleware to my app. After moving it to end of the mw chain it's working as expected. Closing this one, thanks for help :)

[ekryski]

@rafalszemraj no problem. I added a comment in the docs about this because I think it's an easy mistake to make. It happens all the time with Express.