This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
Refactoring to fix hook execution order and all-hooks #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I might add /cc @ekryski, @marshallswain |
|
I pulled it down and it works great! Nice stuff. |
daffl
added a commit
that referenced
this pull request
Feb 4, 2015
Refactoring to fix hook execution order and all-hooks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a bigger refactoring that fixes the hook execution order (closes #13) and adds support for before-all and after-all hooks (closes #11). New tests added and old tests didn't need to be changed (so we can assume backwards compatibility).