Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Comment: Adding authentication (guides/chat/authentication.md) channel.js already set up correctly #984

Closed
aral opened this issue Dec 22, 2017 · 2 comments · Fixed by #997

Comments

@aral
Copy link
Contributor

aral commented Dec 22, 2017

Under “Securing real-time events”, it says: “by updating src/channels.js to this”.

The code that follows is exactly that the generator already created (Feathers version 3.4.1) (apart from a few commented out lines that are removed in the code listing but exist in the generated file).

Should this section be removed or re-written?

@aral
Copy link
Contributor Author

aral commented Dec 22, 2017

Just saw the comment in the paragraph following the code listing:

“This is almost the same as the original file except for the line return app.channel('authenticated'); being commented in app.publish(). Now only authenticated users will receive real-time updates.”

On 3.4.1, the line was not commented out.

@daffl
Copy link
Member

daffl commented Dec 22, 2017

Yep, I changed it in feathersjs-ecosystem/generator-feathers#324 but didn't get to updating the guide.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants