Add a toJSON bundled hook like mongoose

[ekryski]

No description provided.

[daffl]

I'm wondering if we should start the common hook collection module right away and provide a transform hook that does something like

var transform = require('feathers-common-hooks/transform');

app.service('todos').after(transform('toJSON'));
app.service('todos').after(transform(function(data) {
 // Do something here
}));

Which in the first case will call hook.result.toJSON and in the second run the function.

[ekryski]

Ya I'm liking that idea. Especially because we have to handle arrays and pagination sometimes I can see that as a potential pitfall if people have to implement the hooks themselves.

[ekryski]

No longer required as of v2.0.0 since it returns regular JS objects by default.

[subodhpareek18]

I think this is still required.

I have use case of few related models. Upon using include, by default the values returned are firstly flattened out:

{
   "role.roleId": "",
   "role.name": ""
}

instead of

{
  "role": {
    "roleId": "",
    "name": ""
  }
}

Just this would've been fine as it'd be easy to convert the first result to second. But the real issue comes when the included results are an array, in which case the above result doesn't contain all values, just one. (Let's say if roles had a bunch of permissions related to it, it'd just return one permission and not all)

So there is no option but to use { raw: false } on the models. Which of course breaks hooks like discard remove and many more I imagine.

[subodhpareek18]

Though of course a very simple solution exists:

all: [
  hook => ({
    ...hook,
    result: hook.result.toJSON()
  }),
  discard('password')
]

But I'd say a transform hook is still a good idea, because the explicit presence of it in the docs will really help people.

[eikaramba]

I just updated my dependencies and now my results are also flattened like above. Why is that the case? That does not make sense for me.