Can't use modifiers in update method after upgrade to 2.6.1

[exah]

Steps to reproduce

Use update method in nedb service with modifiers (like $push, $pull, etc.).

projectsService.update('projectId', { $push: { 'data.caption': '' } )

Produces error when using [email protected].

Error: You cannot mix modifiers and normal fields

System configuration

Module versions: 2.6.1

NodeJS version: 6.9.5

Operating System: macOS 10.12 / docker node:6 container

Module Loader: [email protected]

---

Working normally @2.6.0.
Somehow related to this: v2.6.0...v2.6.1#diff-1fdf421c05c1140f6d71444ea2b27638

[daffl]

Fixed in v2.6.1

[exah]

Thanks!

[bugss]

use nedb you can not do this

yourService.update(id, {
        $inc: {
          good: 1
        },
        createdAt:new Date()
      })

property name start with $ and property name not start with $ Can not appear at the same time

so when you set a hooks like this

exports.before = {
  all: [],
  find: [],
  get: [],
  create: [hooks.setCreatedAt(), hooks.setUpdatedAt()],
  update: [hooks.setUpdatedAt()],
  patch: [],
  remove: []
};

and some where just call the below code with the before hook above will always exception(You cannot mix modifiers and normal fields)

yourService.update(id, {
        $inc: {
          good: 1
        }
      })

if you want add timestamp . just remove the hook but set timestampData to true

const db = new NeDB({
    filename: path.join(app.get('nedb'), 'posts.db'),
    autoload: true,
    timestampData: true
  });

I think it's a good idea to put these into a document

[marshallswain]

@bugss absolutely. Would you mind making a PR to the auk docs?

It's this page: https://docs.feathersjs.com/v/auk/api/databases/nedb.html
which is here in the repo: https://github.com/feathersjs/feathers-docs/edit/auk/api/databases/nedb.md

[bugss]

feathersjs-ecosystem/docs#457
just add the default config timestampData: true .
Should be able to reduce the possibility of reporting this exception

[pirsplus]

I don't know if that could help you to solve the issue and pull a new request.

In nedb, if you do this :

db.collection.update({ _id: 'MYID'  },  { key: 'value' , $push: { key: 'value' } }, { returnUpdatedDocs: true, multi: false }, (err, num, doc) => {
  // Error: You cannot mix modifiers and normal fields
})

But, if you use 2 modifiers $set and $push (or whatever)

db.collection.update({ _id: 'MYID'  }, { $set: { key: 'value' }, $push: { key: 'value' } }, { returnUpdatedDocs: true, multi: false }, (err, num, doc) => {
  // will be ok
})

The trick is to use $set everytime and you could add any modifiers you want.