Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documents #5

Closed
lokenx opened this issue Nov 8, 2015 · 2 comments
Closed

Updating documents #5

lokenx opened this issue Nov 8, 2015 · 2 comments

Comments

@lokenx
Copy link

lokenx commented Nov 8, 2015

Been giving NeDB a try and just found a small improvement for the docs. For the update method it's currently using just the id property to select the document, whereas NeDB typically supports any query that find also supports.

Some mention of this, and any other slightly changes from the default NeDB behaviour would be helpful!

@ekryski
Copy link
Member

ekryski commented Nov 13, 2015

@lokenx thanks for pointing that out!

We'll prioritize that as a special update to NeDB. We're making sure all the database adapters have a consistent API first. Then we'll circle back to expose some of the specific functionality that each db provides.

As always, feel free to ship a PR as that would help get it in sooner. 😃

@daffl
Copy link
Member

daffl commented Jan 23, 2016

This should work now with the new service functionality using service.update(null, params) or service.patch(null, params).

@daffl daffl closed this as completed Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants