Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for use with feathers-hooks #25

Closed
daffl opened this issue Oct 28, 2015 · 3 comments
Closed

Add documentation for use with feathers-hooks #25

daffl opened this issue Oct 28, 2015 · 3 comments

Comments

@daffl
Copy link
Member

daffl commented Oct 28, 2015

As came up in the issue at feathersjs-ecosystem/feathers-hooks#23, modifying the Mongoose models this adapter returns in a hook can cause some unexpected behaviour. We probably want to add some documentation and with Feathers 2.0 some hooks in this repository that help dealing with this.

@marshallswain
Copy link
Member

Here's what I think this needs:

  • A configurable toObject hook.
  • Docs.

I think other hooks can be added later, but this one's pretty important, IMO.
http://mongoosejs.com/docs/api.html#document_Document-toObject

@ekryski
Copy link
Member

ekryski commented Nov 24, 2015

Agreed. We also might see some nice patterns emerge with some of the other ORM adapters coming out soon.

@ekryski
Copy link
Member

ekryski commented Jan 8, 2016

This was closed with PR #33.

@ekryski ekryski closed this as completed Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants