Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.assign not available in older Node versions #13

Closed
daffl opened this issue Nov 11, 2015 · 4 comments
Closed

Object.assign not available in older Node versions #13

daffl opened this issue Nov 11, 2015 · 4 comments

Comments

@daffl
Copy link
Member

daffl commented Nov 11, 2015

It looks like that is the only incompatibility with Node 0.12 so it might make sense to change that and/or use a polyfill.

@ekryski
Copy link
Member

ekryski commented Nov 13, 2015

Do we care about supporting node 0.12? I guess we should talk about what versions make sense to support, especially since versions in Node are rolling along like God damn freight train right now.

@daffl
Copy link
Member Author

daffl commented Nov 13, 2015

True but there's still many people on older versions and since it would only be a minor change in this case we might want to consider it. In general I would say that every official plugin should support every Node version the latest Feathers release it is compatible with supports.

@ekryski
Copy link
Member

ekryski commented Nov 14, 2015

👍 I'm down with that.

@daffl
Copy link
Member Author

daffl commented Nov 14, 2015

It is actually pretty easy to add the Polyfill to Babel like this: feathersjs-ecosystem/configuration@b21b066 (this repo might need to be updated to latest Babel though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants