This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Add expandPaths option to en/disable options.as path expansion
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! This makes sense and will be released shortly. Would you mind adding it to the documentation at https://docs.feathersjs.com/api/authentication/hooks.html as well? |
|
@daffl Could you publish this new version in the meantime ? I need it for a current projet on which i'm blocked because of this issue (i'm upgrading from a previous version of feathers) |
|
If you make a PR against the documentation with a quick note for the option I'll be more than happy to. |
ghost
mentioned this pull request
|
@daffl Here you go. Tell me if it's properly done ;) |
daffl
pushed a commit
to feathersjs/docs
that referenced
this pull request
Oct 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt to fix for the issue identified in #22 where nested query properties aren't supported by some DB adapters (namely Mongoose and RethinkDB).
The fix simply adds a new
expandPathsoption to both thequeryWithCurrentUserandrestrictToOwnerhooks.expandPathsdefaults to true to preserve current behaviour.restrictToOwnersimply passes theexpandPathsoption toqueryWithCurrentUserforfindoperations.