This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Changed hooks to use hook.service instead of this
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem that hooks lose context of this when used inside other hooks. Fixes feathersjs-ecosystem#17: Hook "restrictToOwner" looses context (this) when wrapped
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the problem that hooks lose context of this when used inside
other hooks.
Other Information
Since I haven't contributed to feathers that much, I am not sure if this change is breaking something in older versions. This change depends on that, the hook object contains a service object, that provides the functionality to find, get, create, etc. of the current service that the hook is in.
The tests created the mock service under
hook.appand I have now moved it under thehookobject.