Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

'authentication' or 'auth' #13

Closed
sonycamera opened this issue May 8, 2017 · 1 comment
Closed

'authentication' or 'auth' #13

sonycamera opened this issue May 8, 2017 · 1 comment

Comments

@sonycamera
Copy link

To get the authentication options, some hooks call hook.app.get('authentication') and others call hook.app.get('auth'). e.g,
options = Object.assign({}, defaults, hook.app.get('authentication'), options);
in following hooks:
has-role-or-restrict.js,
associate-current-user.js,
restrict-to-owner.js,
query-with-current-user.js
and
options = Object.assign({}, defaults, hook.app.get('auth'), options);
in following hooks:
restrict-to-roles.js,
owner-or-restrict-changes.js

But in feathers-authentication plugin, it just set('auth', options). Is this(using key 'authentication') a bug?

@marshallswain
Copy link
Member

I'm pretty sure it's a bug. We want the defaults to match the generator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants