-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon request: QR Code #598
Comments
@colebemis @locness3 @Aviortheking How does this look? |
Have tyou made it by yourself ? BTW, please check you are conform with #171 . |
@locness3 I looked at the font-awesome design and then tried to use #171, although I'm not quite sure I did a good job ... but yes, I made it by myself. |
Instead of doing what you're doing, use squares with 2px borders. |
@locness3 so no rounded edges ... but 2px borders? |
You should round edges with a 90degree angles (as states #171 |
@locness3 I have updated the icon ... please take a look! |
You should round the bottom-right thing, and make it a compound path. |
More than just rounding them, you should make them strokes, no fills are allowed. |
@locness3 I have refactored with all of your changes ... unfortunately, it was really hard for me to get the two squares in the bottom-right thing to be apart of the rest of the vector for the bottom-right thing ... hopefully, this isn't a problem! |
When you will have rounded the two squares at the bottom right, that will be perfect! |
@locness3 Not exactly quite sure how I'm supposed to round the square, as when I try to round them, they either change to nothing or a ring 😞 ... but, if I change the stroke width to 1px (which is clearly against #171), I get a perfectly rounded square! |
on Figma a single point with stroke isn't shown at all so don't worry about that |
Do a single path point with a stroke |
@locness3 How exactly do you do a "single path point with a stroke"? |
Create one path point with your habitual pen tool I guess |
@locness3 Doesn't work ... when I try to do this, by creating a point with the pen tool, it doesn't show up even after I select different strokes |
Have you tried exporting it and oprening in a browser ? |
@locness3 Just did ... not showing up |
🤔 |
I'd like to suggest another design for the QR code icon: This is heavily influenced by several Indonesian digital wallet apps that bear similar icons: I decided to use a rounded square on the bottom-right corner to be distinguishable from others, so people may still be able to interpret this as a normal QR code. You can have a look of the SVG file at https://drive.google.com/open?id=14nO2J2PaODXfcgmB7ZIc3SXf4RPHzXQZ |
Idk, what do you think @johnletey ? |
You've got the Font-Awesome flag in there, so no, I wouldn't do it like this. |
Would like to make a suggestion here - Figma link |
@krrohitch To me, this is more "scan qr code" than "qr code". |
You have a point there. I'll try one without the outer frame. |
@arjasco Unfortunately, that icon has fills in it - which is against the Feather icon guidelines. @krrohitch Well done 😍 Would love to see those icons add to @featherity 😉 |
@johnletey Understood! It wasn't meant to be a candidate for this icon, just a play on an idea before coming to this issue. How could we see the icon @krrohitch has produced make it in? This repo seems like is really isn't getting much attention which is a shame because it's a great icon set. Does the mentioned fork contain all the current icons? I'm currently creating an SVG map with a subset of the icons I require, annoyingly could really do with a QR code one |
@arjasco Understand 😄 And yes, the fork is actively maintained by myself and the contributors. @ericfennis is working hard on publishing usable packages! (lucide-icons/lucide#52) |
@johnletey Looks great! Will keep an eye on the improvements and might look to swapping to this. Thanks! |
Been wanting to use the native feather QR-Code icon for a while and ending up using a work-around. Has the completed icon been published? |
Yeah, one has been merged to a fork of Feather icons - see lucide-icons/lucide#141 |
Thank you. I was wondering if there is a plan to add it to feather icon set natively? |
Bump, i would love this :) |
This icon is available in @lucide-icons, a community fork of Feather : https://lucide.dev/icon/qr-code?search=qr |
Thanks for the information! :) But wouldn't it be nice to merge it to the main repo? For example, my usecase is to use the icons via React Native Feather which - as far as I know - only has access to the main icons and has no built in api to configure it to use the community fork. Im curious, whats the "right" way to go about this, should I make an effort to combine React Native Feather with the community icons, or should @feathericons include more community icons? |
Lucide also has a standalone package for React Native, and has a whopping 975 icons compared to Feather's 287, I would advise you to just switch over to |
Oh, nice. Thanks for pointing that out. Almost makes me feel like a traitor, but in that case I'm gonna switch to lucide icons :D |
Yes it would be. But the repository has no active maintainers. |
Icon Request
font-awesome: https://fontawesome.com/icons/qrcode
mdi: https://materialdesignicons.com/icon/qrcode-scan
The text was updated successfully, but these errors were encountered: