Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on net462 #16

Open
deleteLater opened this issue Jan 11, 2024 · 2 comments
Open

Run tests on net462 #16

deleteLater opened this issue Jan 11, 2024 · 2 comments
Assignees
@deleteLater
Labels
enhancement New feature or request

Comments

@deleteLater
Copy link
Contributor

deleteLater commented Jan 11, 2024 •
edited
Loading

We should run our tests on both net462 and net6.0, currently we only run these tests on net6.0.

featbit-dotnet-sdk/tests/FeatBit.ServerSdk.Tests/FeatBit.ServerSdk.Tests.csproj

Line 4 in 016f87b

<TargetFramework>net6.0</TargetFramework>

See #15
@deleteLater deleteLater self-assigned this Jan 11, 2024
@deleteLater deleteLater added the enhancement New feature or request label Jan 11, 2024
@deleteLater deleteLater moved this to Backlog in FeatBit Jan 11, 2024
@krokofant
Copy link

krokofant commented Jan 11, 2024 •
edited
Loading

I imagine the job needs to target the windows-latest runner and use the vstest-action. Since the test target is already net6.0 I understand that there might be compatibility issues if the target is changed as-is since unsupported APIs might be used in the test setup.

@deleteLater
Copy link
Contributor Author

Yeah, to run the tests on net462, we do need to change some of the test code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deleteLater deleteLater

Labels
enhancement New feature or request
Projects
FeatBit
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krokofant @deleteLater