Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature set spec with reserved spec should not be allowed to be registered #818

Closed
khorshuheng opened this issue Jun 23, 2020 · 1 comment · Fixed by #819
Closed

Feature set spec with reserved spec should not be allowed to be registered #818

khorshuheng opened this issue Jun 23, 2020 · 1 comment · Fixed by #819
Labels

Comments

@khorshuheng
Copy link
Collaborator

Expected Behavior

If a feature spec contains reserved column name such as created_timestamp, Feast should not allow the feature set to be registered at all.

Current Behavior

The feature set get registered, and job update fails due to duplicated column in bigquery schema.

Steps to reproduce

Create a feature spec that contains reserved column name.

Possible Solution

Feast client should perform verification on feature set spec prior to registering the feature set to Feast core.

@woop woop added the kind/bug label Jun 23, 2020
@woop
Copy link
Member

woop commented Jun 23, 2020

Can we enumerate these?

These come to mind

  1. created_timestamp
  2. event_timestamp
  3. ingestion_id
  4. job_id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants