Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for Feast database upgrades #745

Closed
pmjacinto opened this issue May 27, 2020 · 3 comments
Closed

Better support for Feast database upgrades #745

pmjacinto opened this issue May 27, 2020 · 3 comments
Labels
kind/process wontfix This will not be worked on

Comments

@pmjacinto
Copy link

Is your feature request related to a problem? Please describe.

#655 (feast 0.5.0) introduced several changes in the DB schema. Some are easier to handle (new columns) but some are harder, for instance the PK of feature_sets changed datatypes from VARCHAR to a BIGINT.

Describe the solution you'd like

As a first approach, could we have a manual DB upgrade script linked, per release, in the changelog? It would make life easier for operators, as we wouldn't need to check multiple issues for DB changes.

I think having something like Flyway integrated into the project, as suggested by @ches, would really help in making this process as painless as possible.

Describe alternatives you've considered

Additional context

@woop
Copy link
Member

woop commented May 27, 2020

Is your feature request related to a problem? Please describe.

#655 (feast 0.5.0) introduced several changes in the DB schema. Some are easier to handle (new columns) but some are harder, for instance the PK of feature_sets changed datatypes from VARCHAR to a BIGINT.

Describe the solution you'd like

As a first approach, could we have a manual DB upgrade script linked, per release, in the changelog? It would make life easier for operators, as we wouldn't need to check multiple issues for DB changes.

I think having something like Flyway integrated into the project, as suggested by @ches, would really help in making this process as painless as possible.

Describe alternatives you've considered

Additional context

Thanks for raising this @pmjacinto. We meant to get around to this. In fact, we should have an upgrade process from 0.4 to 0.5 that describes all the steps needed, which doesnt just include the data model changes but also the steps to upgrading online clients.

@woop
Copy link
Member

woop commented Jun 21, 2020

We're adding Flyway support over here to make this a bit simpler #809

@stale
Copy link

stale bot commented Aug 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 20, 2020
@stale stale bot closed this as completed Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/process wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants