Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Coverage: End to End Tests for Dataflow Runner #595

Closed
mrzzy opened this issue Apr 1, 2020 · 2 comments
Closed

Test Coverage: End to End Tests for Dataflow Runner #595

mrzzy opened this issue Apr 1, 2020 · 2 comments

Comments

@mrzzy
Copy link
Collaborator

mrzzy commented Apr 1, 2020

Is your feature request related to a problem? Please describe.

Currently, Feast's end to end tests only verify correctness with Feast Core's Direct Runner, leaving a gap in test coverage for the Dataflow runner. This is an issue a we are unable to verify that new additions to the codebase work well with the Dataflow runner, requiring PR authors to do error prone manual testing.

Case study: PR #575

  • I submitted small PR Fix runner to string inconsistency #575 which updated how Runners are rendered.
  • Since the PR is relatively small and all the tests pass, I assumed that the PR did not introduce any bugs and didn't do any independent testing on my own.
  • I only discovered that the PR broke the Dataflow runner after it was merged, leaving a known bug on the master branch.

This bug in the PR would have been caught by Feast's test suite, had it tested with the Dataflow runner in addition to the Direct runner.

Describe the solution you'd like
Add End to End Tests using the Dataflow Runner, in additional to the Direct Runner.

@stale
Copy link

stale bot commented Jun 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 21, 2020
@woop
Copy link
Member

woop commented Jun 21, 2020

@woop woop closed this as completed Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants