Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift ingestion feature metrics to after store write #489

Closed
zhilingc opened this issue Feb 24, 2020 · 0 comments · Fixed by #567
Closed

Shift ingestion feature metrics to after store write #489

zhilingc opened this issue Feb 24, 2020 · 0 comments · Fixed by #567
Labels
area/ingestion The ingestion Beam component and storage-related items kind/techdebt
Milestone

Comments

@zhilingc
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Existing metrics collection for ingestion is done in parallel to store writes:

               +
               |
       +-------+--------+
       |                |
+------+-----+   +------+-----+
|            |   |            |
|   store    |   |  metrics   |
|   write    |   |   write    |
|            |   |            |
+------------+   +------------+

While this does give a rough gauge as to what data looks like in flight, it doesn't actually reflect the status of the data in the store, which is ultimately what we are concerned about, since write failures are common.

Describe the solution you'd like
Ideally we want to write metrics POST store writes, as so:

              ...
               +
               |
         +-----+-----+
         |           |
         |   store   |
         |   write   |
         |           |
         +-----+-----+
               |
      +--------+--------+
      +                 +
   success           failure
      +                 +
      |                 |
+-----+-----+     +-----+-----+
|  write    |     |  write    |
|  sucess   |     |  failure  |
|  metrics  |     |  metrics  |
+-----------+     +-----------+

Metrics collected post store writes would more accurately reflect the data in the stores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ingestion The ingestion Beam component and storage-related items kind/techdebt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants