Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to choose database name when using DatastoreOnlineStore #4113

Closed
Pawel-Drabczyk opened this issue Apr 18, 2024 · 3 comments · Fixed by #4180
Closed

Add possibility to choose database name when using DatastoreOnlineStore #4113

Pawel-Drabczyk opened this issue Apr 18, 2024 · 3 comments · Fixed by #4180
Labels
kind/feature New feature or request

Comments

@Pawel-Drabczyk
Copy link
Contributor

Pawel-Drabczyk commented Apr 18, 2024

Is your feature request related to a problem? Please describe.
When introducing Firestore in Datastore mode in place of Datastore, Google added a possibility to create multiple databases other than (default) (in Datastore there was only one database called (default)). Class DatastoreOnlineStore still doesn't support using a database with another name.

Describe the solution you'd like
I would like to have possibility to choose database name when using DatastoreOnlineStore

Describe alternatives you've considered
The alternative is using the (default) database. However, it has some disadvantages e.g. it doesn't allow fine-grained permissions for each user.

Additional context
Google Datastore client supports passing database when initializing the client.

@Pawel-Drabczyk Pawel-Drabczyk added the kind/feature New feature or request label Apr 18, 2024
@tokoko
Copy link
Collaborator

tokoko commented Apr 19, 2024

thanks, would you like to open a PR for this?

@Pawel-Drabczyk
Copy link
Contributor Author

thanks, would you like to open a PR for this?

Sure, I will try to prepare sth on Monday :)

@Pawel-Drabczyk
Copy link
Contributor Author

@tokoko, I have created a PR #4180, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants