Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FileOfflineStore to DaskOfflineStore #3864

Closed
tokoko opened this issue Dec 10, 2023 · 0 comments · Fixed by #4349
Closed

Rename FileOfflineStore to DaskOfflineStore #3864

tokoko opened this issue Dec 10, 2023 · 0 comments · Fixed by #4349
Labels
kind/feature New feature or request

Comments

@tokoko
Copy link
Collaborator

tokoko commented Dec 10, 2023

FileOfflineStore uses dask under the hood and is in principle no different from any other offline store implementation that can work with file-based data formats. The name doesn't currently reflect that because the underlying execution engine was switched from pandas to dask later on. While the name is probably not important, I think the name change will be valuable to highlight that feast doesn't require one-to-one relationship between DataSources and OfflineStores. The related FileSource class (which should NOT be renamed) can be made to be used from other offline stores, for example SparkOfflineStore.

For backwards-compatibility, we can keep all user-facing classes (FileOfflineStore and maybe also FileRetrievalJob, FileOfflineStoreConfig) as aliases pointing to their new counterparts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant