Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feast serving URL should not be required #344

Closed
woop opened this issue Dec 4, 2019 · 0 comments · Fixed by #353
Closed

Feast serving URL should not be required #344

woop opened this issue Dec 4, 2019 · 0 comments · Fixed by #353

Comments

@woop
Copy link
Member

woop commented Dec 4, 2019

Currently the Python SDK requires the Feast Serving URL to be defined when calling the version() method. The failure here should be graceful.

ValueErrorTraceback (most recent call last)
<ipython-input-31-b8a3b34abdf1> in <module>
----> 1 client.version()

/opt/notebooks/feast/sdk/python/feast/client.py in version(self)
    105 
    106         self._connect_core()
--> 107         self._connect_serving()
    108 
    109         core_version = ""

/opt/notebooks/feast/sdk/python/feast/client.py in _connect_serving(self, skip_if_connected)
    179         if self.__serving_channel is None:
    180             self.__serving_channel = grpc.insecure_channel(self.serving_url)
--> 181 
    182         try:
    183             grpc.channel_ready_future(self.__serving_channel).result(

ValueError: Please set Feast Serving URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant