feat: Add mysql as online store

[hao-affirm]

Signed-off-by: hao-affirm [email protected]

What this PR does / why we need it:
Add mysql as a online store

Which issue(s) this PR fixes:

Fixes #

[codecov-commenter]

Codecov Report

Base: 67.03% // Head: 75.48% // Increases project coverage by +8.44% 🎉

Coverage data is based on head (0d7d831) compared to base (b4ef834).
Patch coverage: 39.81% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3190      +/-   ##
==========================================
+ Coverage   67.03%   75.48%   +8.44%     
==========================================
  Files         175      214      +39     
  Lines       15941    18031    +2090     
==========================================
+ Hits        10686    13610    +2924     
+ Misses       5255     4421     -834     

Flag	Coverage Δ
integrationtests	66.85% <ø> (-0.19%)	⬇️
unittests	57.79% <39.81%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/repo_config.py	87.83% <ø> (+5.32%)	⬆️
setup.py	0.00% <ø> (ø)
.../online_stores/contrib/mysql_online_store/mysql.py	35.86% <35.86%> (ø)
...tion/feature_repos/universal/online_store/mysql.py	53.84% <53.84%> (ø)
.../online_stores/contrib/mysql_repo_configuration.py	100.00% <100.00%> (ø)
...on/feast/infra/materialization/snowflake_engine.py	92.09% <0.00%> (-0.51%)	⬇️
sdk/python/feast/infra/online_stores/snowflake.py	98.16% <0.00%> (-0.02%)	⬇️
sdk/python/feast/infra/provider.py	77.94% <0.00%> (ø)
sdk/python/feast/infra/passthrough_provider.py	96.29% <0.00%> (ø)
sdk/python/feast/infra/offline_stores/snowflake.py	93.30% <0.00%> (ø)
... and 109 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[felixwang9817]

looks pretty good overall!

lint errors need to be fixed

also, if you want this online store contribution to be more public, you should feel free to add some docs for it as the guide suggests! specifically you can add docs to Gitbook by following the steps here and you can add docs to RTD in sdk/python/docs/index.rst (the structure should be pretty self-explanatory, and you can check the results with make html)

[achals]

This is awesome, thanks for the contribution @hao-affirm !! I've left some questions/comments but it looks mostly great.

[hao-affirm]

@felixwang9817 @achals any reason

feast/sdk/python/feast/feature_store.py

Line 550 in c19d640

self.config.online_store and self.config.online_store.type == "sqlite"

that we can not use other db like mysql?

[felixwang9817]

/lgtm

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, hao-affirm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[felixwang9817]

hey @hao-affirm sorry for the delay on the review here - I just stamped it!

in terms of enabling plan for mysql, there's no inherent reason why it can't be done - it should be a reasonably easy change to make, but I think it should come in a follow up PR