Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaving "online_store" key out of "aws" provider in feature_store.yaml produces error #1809

Closed
akuma12 opened this issue Aug 27, 2021 · 3 comments · Fixed by #2224
Closed

Comments

@akuma12
Copy link

akuma12 commented Aug 27, 2021

Is your feature request related to a problem? Please describe.
In feature_store.yaml, if your provider is set to aws, and you leave out the online_store key, it will produce the errors:

  File "pydantic/main.py", line 406, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for RepoConfig
__root__ -> online_store -> region
  field required (type=value_error.missing)

feast.repo_config.FeastConfigError: 1 validation error for RepoConfig
__root__ -> online_store -> region
  field required (type=value_error.missing)
at /Users/jimrohrer/Projects/feast-demo/demo/feature_store.yaml

Describe the solution you'd like
Ideally online_store would be an optional key. In our case we don't need an online store currently.

Describe alternatives you've considered
For now I've just set the online_store to sqlite, which let me continue on.

@fcas
Copy link

fcas commented Sep 14, 2021

I have the same scenario.

@adchia adchia added good first issue Good for newcomers kind/bug labels Jan 5, 2022
@adchia
Copy link
Collaborator

adchia commented Jan 5, 2022

Thanks for filing this! This should be relatively easy to pick up for someone in the community. The parsing happens roughly in that error and I think it should be as simple as changing the type of the online_store in RepoConfig

@mirayyuce
Copy link
Contributor

Looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants