Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional configuration options for Spark jobs #1168

Closed
mike0sv opened this issue Nov 16, 2020 · 2 comments
Closed

Additional configuration options for Spark jobs #1168

mike0sv opened this issue Nov 16, 2020 · 2 comments
Labels
kind/feature New feature or request wontfix This will not be worked on

Comments

@mike0sv
Copy link
Contributor

mike0sv commented Nov 16, 2020

Is your feature request related to a problem? Please describe.
Now there is no way to provide additional configuration options for spark jobs. For example, this is required to provide credentials for s3 storage.

Describe the solution you'd like
I'm using python sdk, so I dont know if this can be replicated in java and go, but my proposal is to add a configuration option, something like FEAST_SPARK_ADDITIONAL_OPTS which can be set to something like "option1=value1;option2=value2" and this options would be added in spark_submit method for standalone, dataproc_sumbit for dataproc and _submit_emr_job for emr.
We need to carefully pick the right format for this configuration option, considering there might be ; or = in option names or values.

Describe alternatives you've considered
Maybe explicitly provide those options with every client.start.... call, but it would break existing api, so it is way worse in my opinion.

@woop
Copy link
Member

woop commented Nov 16, 2020

my proposal is to add a configuration option, something like FEAST_SPARK_ADDITIONAL_OPTS which can be set to something like "option1=value1;option2=value2"

Sounds good to me.

@woop woop added the kind/feature New feature or request label Nov 16, 2020
@stale
Copy link

stale bot commented Jan 15, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 15, 2021
@stale stale bot closed this as completed Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants