Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise ingestion store classes to match architecture #109

Closed
tims opened this issue Jan 27, 2019 · 1 comment
Closed

Reorganise ingestion store classes to match architecture #109

tims opened this issue Jan 27, 2019 · 1 comment

Comments

@tims
Copy link
Contributor

tims commented Jan 27, 2019

Is your feature request related to a problem? Please describe.
The store classes in ingestion are currently all mixed into a single storage package. This makes it difficult to see that there should be a clear distinction between serving stores, warehouse stores, and errors stores.

Describe the solution you'd like
I'd like to propose the following package structure

  • feast.store.warehouse
  • feast.store.serving
  • feast.store.errors

feast.store, will be used for any common classes and interfaces. Naming conventions should follow a similar style to the "source" package.

@tims
Copy link
Contributor Author

tims commented Jan 27, 2019

this follows a change in #61

@tims tims mentioned this issue Jan 27, 2019
@tims tims closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant