From 9ac7f4ea77357219fc8420f05e493767bc5357c2 Mon Sep 17 00:00:00 2001 From: Harri Lehtola <1781172+peruukki@users.noreply.github.com> Date: Thu, 26 Sep 2024 14:03:01 +0300 Subject: [PATCH] fix: Remove unnecessary peer dependencies from Feast UI (#4577) --- docs/reference/alpha-web-ui.md | 7 +++++-- ui/README.md | 7 +++++-- ui/package.json | 21 +++++++++------------ 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/docs/reference/alpha-web-ui.md b/docs/reference/alpha-web-ui.md index 2caeed9e2a..02dd107f1b 100644 --- a/docs/reference/alpha-web-ui.md +++ b/docs/reference/alpha-web-ui.md @@ -45,11 +45,14 @@ Start with bootstrapping a React app with `create-react-app` npx create-react-app your-feast-ui ``` -Then, in your app folder, install Feast UI and its peer dependencies. Assuming you use yarn +Then, in your app folder, install Feast UI and optionally its peer dependencies. Assuming you use yarn ``` yarn add @feast-dev/feast-ui -yarn add @elastic/eui @elastic/datemath @emotion/react moment prop-types inter-ui react-query react-router-dom use-query-params zod typescript query-string d3 @types/d3 +# For custom UI using the Elastic UI Framework (optional): +yarn add @elastic/eui +# For general custom styling (optional): +yarn add @emotion/react ``` Edit `index.js` in the React app to use Feast UI. diff --git a/ui/README.md b/ui/README.md index 852bddc296..a2326e1a9e 100644 --- a/ui/README.md +++ b/ui/README.md @@ -21,11 +21,14 @@ Start with bootstrapping a React app with `create-react-app` npx create-react-app your-feast-ui ``` -Then, in your app folder, install Feast UI and its peer dependencies. Assuming you use yarn +Then, in your app folder, install Feast UI and optionally its peer dependencies. Assuming you use yarn ``` yarn add @feast-dev/feast-ui -yarn add @elastic/eui @elastic/datemath @emotion/react moment prop-types inter-ui react-query react-router-dom use-query-params zod typescript query-string d3 @types/d3 +# For custom UI using the Elastic UI Framework (optional): +yarn add @elastic/eui +# For general custom styling (optional): +yarn add @emotion/react ``` Edit `index.js` in the React app to use Feast UI. diff --git a/ui/package.json b/ui/package.json index bc2a71378a..9524944db5 100644 --- a/ui/package.json +++ b/ui/package.json @@ -9,21 +9,18 @@ "types": "./dist/FeastUI.d.ts", "module": "./dist/feast-ui.module.js", "peerDependencies": { - "@elastic/datemath": "^5.0.3", "@elastic/eui": "^55.0.1", "@emotion/react": "^11.7.1", - "d3": "^7.3.0", - "inter-ui": "^3.19.3", - "moment": "^2.29.1", - "prop-types": "^15.8.1", - "query-string": "^7.1.1", "react": "^17.0.2", - "react-dom": "^17.0.2", - "react-query": "^3.34.12", - "react-router-dom": "<6.4.0", - "react-scripts": "^5.0.0", - "use-query-params": "^1.2.3", - "zod": "^3.11.6" + "react-dom": "^17.0.2" + }, + "peerDependenciesMeta": { + "@elastic/eui": { + "optional": true + }, + "@emotion/react": { + "optional": true + } }, "dependencies": { "@elastic/datemath": "^5.0.3",