From 6912a41794d8306808dca60ebf6ba90ceac15898 Mon Sep 17 00:00:00 2001 From: Danny Chiao Date: Wed, 20 Oct 2021 14:12:11 +0000 Subject: [PATCH] GitBook: [#314] Remove data creator cleanup since it breaks tests (from 0.14 branch) --- docs/how-to-guides/adding-or-reusing-tests.md | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/docs/how-to-guides/adding-or-reusing-tests.md b/docs/how-to-guides/adding-or-reusing-tests.md index 23ca961e8c..72d2d815e4 100644 --- a/docs/how-to-guides/adding-or-reusing-tests.md +++ b/docs/how-to-guides/adding-or-reusing-tests.md @@ -150,9 +150,9 @@ The key fixtures are the `environment` and `universal_data_sources` fixtures, wh To: -* Include a new offline store: +* Include a new offline store: * extend `data_source_creator.py` for your offline store - * in `repo_configuration.py` add a new`IntegrationTestRepoConfig` or two \(depending on how many online stores you want to test\) + * in `repo_configuration.py` add a new`IntegrationTestRepoConfig` or two (depending on how many online stores you want to test) * Run the full test suite with `make test-python-integration` * See more guidelines at [https://github.com/feast-dev/feast/issues/1892](https://github.com/feast-dev/feast/issues/1892) * Include a new online store: @@ -161,10 +161,10 @@ To: * Run the full test suite with `make test-python-integration` * See more guidelines at [https://github.com/feast-dev/feast/issues/1892](https://github.com/feast-dev/feast/issues/1892) * Add a new test to an existing test file: - * Use the same function signatures as an existing test \(e.g. have environment as an argument\) to include the relevant test fixtures. + * Use the same function signatures as an existing test (e.g. have environment as an argument) to include the relevant test fixtures. * We prefer to expand what an individual test covers due to the cost of standing up offline / online stores * Using custom data in a new test: - * This is used in several places such as `test_universal_types.py` + * This is used in several places such as `test_universal_types.py` ```python @@ -180,7 +180,4 @@ def your_test(environment: Environment): fs.apply([fv, entity]) # ... run test - - environment.data_source_creator.teardown() ``` -