From 5560caf0c360a930c038eec8eef3238b8b0faccb Mon Sep 17 00:00:00 2001 From: Achal Shah Date: Mon, 13 Dec 2021 19:41:01 -0800 Subject: [PATCH] Remove underscores from ECR docker versions (#2139) Signed-off-by: Achal Shah --- Makefile | 10 +++------- infra/templates/README.md.jinja2 | 3 ++- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index 2944f9388a..164f6afb54 100644 --- a/Makefile +++ b/Makefile @@ -146,16 +146,12 @@ push-ci-docker: build-ci-docker: docker build -t $(REGISTRY)/feast-ci:$(VERSION) -f infra/docker/ci/Dockerfile . -# Note, we use underscores instead of periods in the version name since ECR doesn't support periods. We automatically -# pull from Docker Hub and push to ECR. push-feature-server-python-aws-docker: - ECR_VERSION=$(shell echo "$(VERSION)" | sed 's/[.]/_/g'); \ - docker push $(REGISTRY)/feature-server-python-aws:$$ECR_VERSION + docker push $(REGISTRY)/feature-server-python-aws:$$VERSION build-feature-server-python-aws-docker: - ECR_VERSION=$(shell echo "$(VERSION)" | sed 's/[.]/_/g'); \ - docker build --build-arg VERSION=$$ECR_VERSION \ - -t $(REGISTRY)/feature-server-python-aws:$$ECR_VERSION \ + docker build --build-arg VERSION=$$VERSION \ + -t $(REGISTRY)/feature-server-python-aws:$$VERSION \ -f sdk/python/feast/infra/feature_servers/aws_lambda/Dockerfile . push-feature-transformation-server-docker: diff --git a/infra/templates/README.md.jinja2 b/infra/templates/README.md.jinja2 index 641b1a75f5..a9277bb070 100644 --- a/infra/templates/README.md.jinja2 +++ b/infra/templates/README.md.jinja2 @@ -6,7 +6,8 @@
[![unit-tests](https://github.com/feast-dev/feast/actions/workflows/unit_tests.yml/badge.svg?branch=master&event=push)](https://github.com/feast-dev/feast/actions/workflows/unit_tests.yml) -[![integration-tests](https://github.com/feast-dev/feast/actions/workflows/integration_tests.yml/badge.svg?branch=master&event=push)](https://github.com/feast-dev/feast/actions/workflows/integration_tests.yml) +[![integration-tests-and-build](https://github.com/feast-dev/feast/actions/workflows/master_only.yml/badge.svg?branch=master&event=push)](https://github.com/feast-dev/feast/actions/workflows/master_only.yml) +[![java-integration-tests](https://github.com/feast-dev/feast/actions/workflows/java_master_only.yml/badge.svg?branch=master&event=push)](https://github.com/feast-dev/feast/actions/workflows/java_master_only.yml) [![linter](https://github.com/feast-dev/feast/actions/workflows/linter.yml/badge.svg?branch=master&event=push)](https://github.com/feast-dev/feast/actions/workflows/linter.yml) [![Docs Latest](https://img.shields.io/badge/docs-latest-blue.svg)](https://docs.feast.dev/) [![Python API](https://img.shields.io/readthedocs/feast/master?label=Python%20API)](http://rtd.feast.dev/)