From 463b88fe7297a981e0c2a1e5687de62bba93ebbb Mon Sep 17 00:00:00 2001 From: Achal Shah Date: Fri, 17 Sep 2021 12:59:11 -0700 Subject: [PATCH] Upload benchmark information to S3 after integration test runs (#1878) * Upload benchmark information to S3 after integration test runs Signed-off-by: Achal Shah * Fix action Signed-off-by: Achal Shah * newline Signed-off-by: Achal Shah --- .github/workflows/integration_tests.yml | 9 +++------ .github/workflows/pr_integration_tests.yml | 9 +++------ .gitignore | 5 ++++- Makefile | 2 +- 4 files changed, 11 insertions(+), 14 deletions(-) diff --git a/.github/workflows/integration_tests.yml b/.github/workflows/integration_tests.yml index ab46d1cb91..fcc7da5a42 100644 --- a/.github/workflows/integration_tests.yml +++ b/.github/workflows/integration_tests.yml @@ -63,9 +63,6 @@ jobs: fail_ci_if_error: true verbose: true - name: Benchmark python - run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-json=./benchmarks.json - - name: Upload Benchmark Artifact - uses: actions/upload-artifact@v2 - with: - name: benchmarks.json - path: benchmarks.json + run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-autosave --benchmark-save-data + - name: Upload Benchmark Artifact to S3 + run: aws s3 cp --recursive .benchmarks s3://feast-ci-pytest-benchmarks diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml index 101e4c4cbb..a4bd234eb9 100644 --- a/.github/workflows/pr_integration_tests.yml +++ b/.github/workflows/pr_integration_tests.yml @@ -74,9 +74,6 @@ jobs: fail_ci_if_error: true verbose: true - name: Benchmark python - run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-json=./benchmarks.json - - name: Upload Benchmark Artifact - uses: actions/upload-artifact@v2 - with: - name: benchmarks.json - path: benchmarks.json + run: FEAST_USAGE=False IS_TEST=True pytest --verbose --color=yes sdk/python/tests --integration --benchmark --benchmark-autosave --benchmark-save-data + - name: Upload Benchmark Artifact to S3 + run: aws s3 cp --recursive .benchmarks s3://feast-ci-pytest-benchmarks diff --git a/.gitignore b/.gitignore index 9559998520..90b1a66a8c 100644 --- a/.gitignore +++ b/.gitignore @@ -187,4 +187,7 @@ dmypy.json # Protos sdk/python/docs/html sdk/python/feast/protos/ -sdk/go/protos/ \ No newline at end of file +sdk/go/protos/ + +#benchmarks +.benchmarks diff --git a/Makefile b/Makefile index 58ba395c56..240ada9196 100644 --- a/Makefile +++ b/Makefile @@ -53,7 +53,7 @@ install-python: python -m pip install -e sdk/python -U --use-deprecated=legacy-resolver benchmark-python: - FEAST_USAGE=False IS_TEST=True pytest --integration --benchmark sdk/python/tests + FEAST_USAGE=False IS_TEST=True pytest --integration --benchmark --benchmark-autosave --benchmark-save-data sdk/python/tests test-python: FEAST_USAGE=False IS_TEST=True pytest -n 8 sdk/python/tests