From 3c94614c5eb60450e3a1506049b0797ce4be444f Mon Sep 17 00:00:00 2001 From: Francisco Arceo Date: Sat, 5 Oct 2024 06:58:00 -0400 Subject: [PATCH] chore: Updated snowflake test to be more explicit about post apply entity_columns return value (#4603) chore: updated snowflake test to be more explicit about post apply entity_column return value Signed-off-by: Francisco Javier Arceo --- .../tests/integration/materialization/test_snowflake.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/python/tests/integration/materialization/test_snowflake.py b/sdk/python/tests/integration/materialization/test_snowflake.py index dc9d684ab5..5598526d2b 100644 --- a/sdk/python/tests/integration/materialization/test_snowflake.py +++ b/sdk/python/tests/integration/materialization/test_snowflake.py @@ -5,7 +5,7 @@ from feast import Field from feast.entity import Entity -from feast.feature_view import FeatureView +from feast.feature_view import DUMMY_ENTITY_FIELD, FeatureView from feast.types import Array, Bool, Bytes, Float64, Int32, Int64, String, UnixTimestamp from feast.utils import _utc_now from tests.data.data_creator import create_basic_driver_dataset @@ -189,7 +189,7 @@ def test_snowflake_materialization_consistency_internal_with_lists( snowflake_environment.data_source_creator.teardown() -@pytest.mark.integration +# @pytest.mark.integration def test_snowflake_materialization_entityless_fv(): snowflake_config = IntegrationTestRepoConfig( online_store=SNOWFLAKE_ONLINE_CONFIG, @@ -225,7 +225,7 @@ def test_snowflake_materialization_entityless_fv(): try: fs.apply([overall_stats_fv, driver]) - assert overall_stats_fv.entity_columns != [] + assert overall_stats_fv.entity_columns == [DUMMY_ENTITY_FIELD] # materialization is run in two steps and # we use timestamp from generated dataframe as a split point