From 2e41b2114586143d5e68b2aeefc3d693284807a3 Mon Sep 17 00:00:00 2001 From: Theodor Mihalache Date: Tue, 6 Aug 2024 10:30:16 -0400 Subject: [PATCH 1/3] fix: removed experimental optional from permission proto Signed-off-by: Theodor Mihalache --- protos/feast/core/Permission.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protos/feast/core/Permission.proto b/protos/feast/core/Permission.proto index aba9f0bb40a..f25583afb48 100644 --- a/protos/feast/core/Permission.proto +++ b/protos/feast/core/Permission.proto @@ -43,7 +43,7 @@ message Permission { bool with_subclasses = 4; - optional string name_pattern = 5; + string name_pattern = 5; map required_tags = 6; From b232ac5c9efe332f45cbe7a5e957b607ad01912c Mon Sep 17 00:00:00 2001 From: Theodor Mihalache Date: Tue, 6 Aug 2024 10:30:16 -0400 Subject: [PATCH 2/3] fix: removed experimental optional from permission proto Signed-off-by: Theodor Mihalache --- sdk/python/feast/permissions/permission.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/python/feast/permissions/permission.py b/sdk/python/feast/permissions/permission.py index cb2e1250f5b..b62fa7c01a1 100644 --- a/sdk/python/feast/permissions/permission.py +++ b/sdk/python/feast/permissions/permission.py @@ -206,7 +206,7 @@ def to_proto(self) -> PermissionProto: name=self.name, types=types, with_subclasses=self.with_subclasses, - name_pattern=self.name_pattern if self.name_pattern is not None else None, + name_pattern=self.name_pattern if self.name_pattern is not None else "", actions=actions, policy=self.policy.to_proto(), tags=self._tags if self._tags is not None else None, From 3d72fed3b386f22343b02f894b0cd39ed591084b Mon Sep 17 00:00:00 2001 From: Theodor Mihalache Date: Tue, 6 Aug 2024 10:45:38 -0400 Subject: [PATCH 3/3] fix: changed java_outer_classname for Permission.proto and Policy.proto Signed-off-by: Theodor Mihalache --- protos/feast/core/Permission.proto | 2 +- protos/feast/core/Policy.proto | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/protos/feast/core/Permission.proto b/protos/feast/core/Permission.proto index f25583afb48..e464164afa0 100644 --- a/protos/feast/core/Permission.proto +++ b/protos/feast/core/Permission.proto @@ -2,7 +2,7 @@ syntax = "proto3"; package feast.core; option go_package = "github.com/feast-dev/feast/go/protos/feast/core"; -option java_outer_classname = "Permission"; +option java_outer_classname = "PermissionProto"; option java_package = "feast.proto.core"; import "feast/core/Policy.proto"; diff --git a/protos/feast/core/Policy.proto b/protos/feast/core/Policy.proto index e4313535ec8..7ad42b9797a 100644 --- a/protos/feast/core/Policy.proto +++ b/protos/feast/core/Policy.proto @@ -2,7 +2,7 @@ syntax = "proto3"; package feast.core; option go_package = "github.com/feast-dev/feast/go/protos/feast/core"; -option java_outer_classname = "Policy"; +option java_outer_classname = "PolicyProto"; option java_package = "feast.proto.core"; message Policy {