Skip to content

Commit

Permalink
Correct workflow filter
Browse files Browse the repository at this point in the history
  • Loading branch information
fcollonval committed Sep 27, 2021
1 parent f824391 commit 4f5b605
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/artifacts-comment.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Comment on pull request
on:
workflow_run:
workflows: ['Test workflow with upload']
workflows: ['Build']
types: [completed]
jobs:
pr_comment:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
run: |
jlpm
jlpm run eslint:check
python -m pip install -e .[dev,tests]
python -m pip install -e .[tests]
# Python formatting checks
black . --check
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install jupyter_packaging~=0.7.9 jupyterlab~=3.0 packaging setuptools twine wheel
pip install jupyter_packaging~=0.7.9 jupyterlab~=3.0 packaging setuptools twine build
- name: Publish the Python package
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.PYPI_API_TOKEN }}
run: |
python setup.py sdist bdist_wheel
python -m build
twine upload dist/*
- name: Publish the NPM package
run: |
Expand Down

0 comments on commit 4f5b605

Please sign in to comment.