Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export link creates unsaved.csv #155

Closed
rafreyes opened this issue Nov 26, 2020 · 9 comments
Closed

Export link creates unsaved.csv #155

rafreyes opened this issue Nov 26, 2020 · 9 comments
Labels

Comments

@rafreyes
Copy link

Hi,
I have encountered an issue when exporting the table (enhanced and document) as CSV through the export links. While the export is successful the filename generated is "unsaved.csv". Would it be possible to have the visualisation's name as the filename?

Thanks a lot for sharing this useful plugin

@fbaligand
Copy link
Owner

Hi,

Thanks to report this bug.
I will try to fix it in next release.

@fbaligand
Copy link
Owner

fbaligand commented Nov 27, 2020

Hi,

I tried to fix this issue, but actually there is no mean to, because vis title information is not provided by Kibana to plugin's controller.

So I just created a PR to Kibana core, so that it provides vis title information to a visualization plugin:
elastic/kibana#84456

Finally, this issue should happen only since Kibana 7.8

@fbaligand
Copy link
Owner

Hi,

My PR on kibana core (elastic/kibana#84456) has been merged and will be available in Kibana 7.11.0.
So this issue will be fixed in Kibana 7.11.0

@rafreyes
Copy link
Author

Hello,
thanks for the feedback. so, we'll wait for the 7.11 version
have a nice day

@fbaligand
Copy link
Owner

Hi,

Waiting for Kibana 11, I just released Enhanced Table v1.11.0, and default name is now export.csv, in Kibana 7.8+.
It is better than "unsaved.csv" :)

@rafreyes
Copy link
Author

rafreyes commented Jan 5, 2021

Hello,

yes, that's better. thank you

have a nice 2021 :)

@fbaligand
Copy link
Owner

Happy new year 2021 !

@fbaligand
Copy link
Owner

As expected, the bug has been solved in Kibana 7.11.
So I close this issue.

@fbaligand
Copy link
Owner

Hi,

Finally, there was also a bug in Enhanced Table plugin code.
I just fixed it in last release (v1.13.3), available here:
https://github.com/fbaligand/kibana-enhanced-table/releases/tag/v1.13.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants