Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 48 removes SVGGraphicsElement.getTransformToElement() #11

Closed
thvitt opened this issue Feb 9, 2016 · 3 comments
Closed

Chrome 48 removes SVGGraphicsElement.getTransformToElement() #11

thvitt opened this issue Feb 9, 2016 · 3 comments
Assignees
Milestone

Comments

@thvitt
Copy link
Member

thvitt commented Feb 9, 2016

Cf. dagrejs/dagre-d3#202

Essentially, this breaks our overlay code, leading to issues such as:

ERROR: failed rendering "out2/svg/diplomatic/archival/agad_warszawa/PL_1_354_13-16-24_20-21.xml" on page 1 from transcript "/home/tv/Faust/transcript/agad_warszawa/PL_1_354_13-16-24/0020.xml"
  Chrome errormessage: 
{
   "text" : "Uncaught TypeError: target.getTransformToElement is not a function",
   "line" : 308,
   "url" : "http://127.0.0.1/faust-gen/js/svg-utils.js",
   "column" : 22,
   "stackTrace" : [
      {
         "columnNumber" : 23,
         "url" : "http://127.0.0.1/faust-gen/js/svg-utils.js",
         "scriptId" : "43",
         "lineNumber" : 308,
         "functionName" : "fitTo"
      },
      {
         "url" : "http://127.0.0.1/faust-gen/js/transcript-generation.js",
         "columnNumber" : 20,
         "lineNumber" : 115,
         "functionName" : "",
         "scriptId" : "53"
      },
      {
         "columnNumber" : 89,
         "url" : "http://127.0.0.1/faust-gen/js/transcript-generation.js",
         "scriptId" : "53",
         "lineNumber" : 110,
         "functionName" : "transcriptGeneration.createFacsimileOverlaySvg.createFacsimileOverlaySvg"
      },
      {
         "url" : "",
         "columnNumber" : 15758,
         "scriptId" : "57",
         "functionName" : "",
         "lineNumber" : 1
      },
      {
         "lineNumber" : 1,
         "functionName" : "",
         "scriptId" : "57",
         "columnNumber" : 15878,
         "url" : ""
      },
      {
         "scriptId" : "54",
         "functionName" : "InjectedScript._evaluateOn",
         "lineNumber" : 875,
         "columnNumber" : 140,
         "url" : ""
      },
      {
         "url" : "",
         "columnNumber" : 34,
         "scriptId" : "54",
         "lineNumber" : 808,
         "functionName" : "InjectedScript._evaluateAndWrap"
      },
      {
         "columnNumber" : 21,
         "url" : "",
         "lineNumber" : 664,
         "functionName" : "InjectedScript.evaluate",
         "scriptId" : "54"
      }
   ]
}
@thvitt
Copy link
Member Author

thvitt commented Feb 9, 2016

Downgrade auf Chromium 47 war erstmal ein Workaround. Nichtsdestotrotz sollte mittelfristig auf etwas umgestellt werden, dass langsamer entwickelt wird bzw. wo alte Versionen leicht verfügbar sind.

@Chleij, @wissenbach, wisst ihr, welche Probleme mit PhantomJS zur Umstellung auf Chromium geführt haben?

@wissenbach
Copy link
Member

Dazu kann @Chleij wahrscheinlich mehr sagen, ich hatte noch mit PhantomJS gearbeitet.

@thvitt
Copy link
Member Author

thvitt commented Jul 18, 2016

Die Umstellung auf PhantomJS hat das erstmal gelöst, #13 existiert immernoch

@thvitt thvitt closed this as completed Jul 18, 2016
@thvitt thvitt added this to the beta.2 milestone Jul 18, 2016
@thvitt thvitt self-assigned this Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants