test_logoff_dot1x test flake

[gizmoguy]

Occasionally the ChewieTestCase.test_logoff_dot1x unit test fails for this reason:

_______________________ ChewieTestCase.test_logoff_dot1x _______________________

self = <test_chewie.ChewieTestCase testMethod=test_logoff_dot1x>

    @patch('chewie.chewie.get_random_id', get_random_id_helper)
    @patch('chewie.chewie.EapSocket', FakeEapSocket)
    @patch('chewie.chewie.RadiusSocket', FakeRadiusSocket)
    @patch('chewie.chewie.MabSocket', FakeMabSocket)
    @patch('chewie.chewie.RadiusLifecycle.generate_request_authenticator', urandom_helper)
    @patch('chewie.chewie.FullEAPStateMachine.next_id', next_id)
    def wrapper_patch(self):
>       func(self)

test/unit/test_chewie.py:42: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
test/unit/test_chewie.py:61: in wrapper_setup_gen
    func(self)
test/unit/test_chewie.py:436: in test_logoff_dot1x
    FullEAPStateMachine.LOGOFF2)
E   AssertionError: 'SUCCESS2' != 'LOGOFF2'
E   - SUCCESS2
E   + LOGOFF2

[gizmoguy]

8a2e9f3 seems to reduce how often this fails, however a better fix than increasing the sleep would be to add a helper which waits until it detects statemachine moving to new state.