Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ensaio in Boule #35

Closed
leouieda opened this issue May 3, 2022 · 8 comments
Closed

Use Ensaio in Boule #35

leouieda opened this issue May 3, 2022 · 8 comments
Milestone

Comments

@leouieda
Copy link
Member

leouieda commented May 3, 2022

Before we commit to v1.0.0 (#2), we should start using it in our other packages.

This issue tracks the progress of implementing this in Boule. Link back to it when opening issues and PRs in the Boule repository. Boule doesn't really any datasets but it would be great to include some gravity disturbance calculations in the docs there, which we currently don't have.

@leouieda leouieda added this to the 1.0.0 milestone May 3, 2022
@aguspesce
Copy link
Member

Hello @leouieda!
I can do this, or you have started working on this issue?

@leouieda
Copy link
Member Author

leouieda commented May 8, 2022

@aguspesce no I haven't. Any help is greatly appreciated 🙂 I can pay in a cute baby appearance during a future meeting

@aguspesce
Copy link
Member

@leouieda, I saw Boule's code and noticed that it doesn't have any datasets to download from Esaio.
I'm wrong?

@leouieda
Copy link
Member Author

You're right, there are no data in Boule at the moment (that was me copy-pasting incorrectly...). So for this it would be a matter of adding it as a documentation dependency and including an example loading the Earth gravity data and calculating normal gravity + the disturbance.

And now that I say that, we should really work to get some Mars and Moon gravity grids onto Ensaio 🌔

@aguspesce
Copy link
Member

@leouieda,
Harmonica has an example where calculate the disturbance (gravity_disturbance).

Do you want to create something similar in Boule?

@leouieda
Copy link
Member Author

@aguspesce I think @santisoler was reworking the examples to focus on the Souther Africa data rather than the global grid for the disturbance. So maybe we can have global disturbance calculation in the Boule docs as a complement? What do you think?

@aguspesce
Copy link
Member

aguspesce commented May 10, 2022

So maybe we can have global disturbance calculation in the Boule docs as a complement? What do you think?

I like the idea! I can create an example for Boule to calculate the gravity disturbance

@leouieda
Copy link
Member Author

Alright, this is done and working both in fatiando/boule#102 and fatiando/boule#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants