Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InferShapes fails after FoldTransposeIntoQuantInit #77

Closed
iksnagreb opened this issue Oct 4, 2023 · 1 comment
Closed

InferShapes fails after FoldTransposeIntoQuantInit #77

iksnagreb opened this issue Oct 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@iksnagreb
Copy link
Contributor

This problem reported over at FINN, see Xilinx/finn#878 and Xilinx/finn#892, probably belongs here. I will try to contribute a fix soon. I think the FoldTransposeIntoQuantInit transform should not apply in cases where the predecessor Quant node has any input which which is not an initializer. However, currently it always deletes the transpose node irrespective of the inputs or initializers.
@iksnagreb iksnagreb added the bug Something isn't working label Oct 4, 2023
@iksnagreb iksnagreb mentioned this issue Oct 5, 2023
Merged
@iksnagreb
Copy link
Contributor Author

As the PR got merged, we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iksnagreb