Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript definitions #35

Closed
mnlfischer opened this issue Jul 16, 2021 · 3 comments
Closed

Add Typescript definitions #35

mnlfischer opened this issue Jul 16, 2021 · 3 comments

Comments

@mnlfischer
Copy link

🚀 Feature Proposal

Add missing Typescript definitions.

Motivation

I would like to use fastify-routes in a Typescript project, especially for testing registered routes. I did not found any type definitions in this project or some definitions from https://www.npmjs.com/~types.

Would be happy if you can support Typescript in the future. I'm not so deep into TS definitions but with some practice I can support.

Example

No example needed.

@mcollina
Copy link
Member

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

Use fastify-static as a starting point.

@mnlfischer
Copy link
Author

I'm on vacation for the next two weeks. I look at it after.

@Fdawgs
Copy link
Member

Fdawgs commented Oct 5, 2021

@mnlfischer has #44 resolved this?

@mcollina mcollina closed this as completed Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants