Change require "url" to "node:url" did make it incompatible with usage inside browser / web

[alexander-schranz]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the bug has not already been reported

Fastify version

Plugin version

2.3.0

Node.js version

v14.21.3

Operating system

macOS

Operating system version (i.e. 20.04, 11.3, 10)

12.7.4

Description

The changes in 6c97e35

seems to break packages which using it as example via webpack in the browser. I'm not 100% sure if this package was created to work inside browser but thought I would report it if it should.

Currently because of node:url the ajv is failing now which is package used for json schema validation in some cases as we in @sulu using it in browser: ajv-validator/ajv#2446

Link to code that reproduces the bug

ajv-validator/ajv#2446

Expected Behavior

Should work inside the browser / web apps compiles with webpack 4 / 5.

Workaround

For all coming from ajv-validator/ajv#2446 you can downgrade ajv to a version not using fast-uri:

npm install "[email protected].*" --save

or downgrade fast-uro to:

npm install "[email protected].*" --save

[LucasLopesr]

same problem here

[Eomm]

Thanks for reporting!
Would you like to send a Pull Request to address this issue? Remember to add unit tests.

It would be great to solve the add browser stack todo item

[alexander-schranz]

@Eomm what ist your recommended solution. Should we just revert #69, or do you have anything else in mind?

And do you have any hint how we can add a test to check if it works inside browser?

[gurgunday]

Please remove to URL import altogether and make it use the global variable

[gurgunday]

I think there is still some work needed to do before we can make fast-uri run on the Web:

#21