Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark that makes measurable use of enum #425

Closed
mdboom opened this issue Jun 29, 2022 · 2 comments
Closed

Add benchmark that makes measurable use of enum #425

mdboom opened this issue Jun 29, 2022 · 2 comments

Comments

@mdboom
Copy link
Contributor

mdboom commented Jun 29, 2022

We had an unexpected regression in enum in the 3.11 cycle and we know from running the profiler over pyperformance that none of the benchmarks spend a significant amount of time dealing with enums.

We should try to add a good benchmark that makes meaningful use of enums, ideally not just an enum microbenchmark, though.

@kmod
Copy link

kmod commented Jul 6, 2022

Shameless plug -- it might be less than you want, but the pyston djangocms and flaskblogging benchmarks spend about 0.5-1% of their time in enum.py

@mdboom
Copy link
Contributor Author

mdboom commented Jul 6, 2022

That's actually really helpful, @kmod. I had been struggling to find something (just by poking around with Github code search). This might get resolved by finishing #175 then.

@mdboom mdboom moved this from In Progress to Todo in Fancy CPython Board Jul 7, 2022
@mdboom mdboom closed this as completed Jul 26, 2022
Repository owner moved this from Todo to Done in Fancy CPython Board Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants