Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up of MavenCoordinate required #338

Closed
proksch opened this issue Nov 23, 2021 · 3 comments
Closed

Clean-up of MavenCoordinate required #338

proksch opened this issue Nov 23, 2021 · 3 comments
Assignees
Labels
maintenance Improvements without changing functionality

Comments

@proksch
Copy link
Contributor

proksch commented Nov 23, 2021

Right now, we have the class MavenCoordinate to abstract away some Maven details... Unfortunately, the class is a big mess and urgently requires a thorough refactoring.

  • It is supposed to be a data structure, but it contains a download method that downloads Maven artifact from a repository. This should be split up into two classes. The data structure and a utils class.
  • The test for the class are still located in the javacg-opal plugin, apparently the class has been moved, but the tests were left in the old place.
  • The tests of CallGraphConstructor are based on the downloading functionality and download actual packages on every build, this is not acceptable. I propose two extensions 1) downloads should be cached in a configurable folder, which should also reduce the network footprint of the FASTEN pipeline. 2) The download logic in MavenCoordinate should be refactored such that it can be mocked for the CallGraphConstructorTest to avoid a download and make the test faster.

Do we have any volunteer that wants to clean up this class?

@mir-am
Copy link
Contributor

mir-am commented Nov 24, 2021

I can take care of the first two tasks. We have MavenUtilties in core which downloads Maven artifacts.
I leave the third task to Mehdi as he's the main developer for the OPAL plug-in.

@mir-am mir-am self-assigned this Nov 24, 2021
@mir-am mir-am added the maintenance Improvements without changing functionality label Nov 24, 2021
@mir-am
Copy link
Contributor

mir-am commented Dec 13, 2021

The first and second tasks were done in #344. I'd like to close the issue. We can do the third task in another issue or PR.

@mir-am mir-am closed this as completed Dec 13, 2021
@proksch
Copy link
Contributor Author

proksch commented Dec 13, 2021

Agreed, but then please open another issue or this will be forgotten. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improvements without changing functionality
Projects
None yet
Development

No branches or pull requests

2 participants