You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, we have the class MavenCoordinate to abstract away some Maven details... Unfortunately, the class is a big mess and urgently requires a thorough refactoring.
It is supposed to be a data structure, but it contains a download method that downloads Maven artifact from a repository. This should be split up into two classes. The data structure and a utils class.
The test for the class are still located in the javacg-opal plugin, apparently the class has been moved, but the tests were left in the old place.
The tests of CallGraphConstructor are based on the downloading functionality and download actual packages on every build, this is not acceptable. I propose two extensions 1) downloads should be cached in a configurable folder, which should also reduce the network footprint of the FASTEN pipeline. 2) The download logic in MavenCoordinate should be refactored such that it can be mocked for the CallGraphConstructorTest to avoid a download and make the test faster.
Do we have any volunteer that wants to clean up this class?
The text was updated successfully, but these errors were encountered:
I can take care of the first two tasks. We have MavenUtilties in core which downloads Maven artifacts.
I leave the third task to Mehdi as he's the main developer for the OPAL plug-in.
Right now, we have the class MavenCoordinate to abstract away some Maven details... Unfortunately, the class is a big mess and urgently requires a thorough refactoring.
javacg-opal
plugin, apparently the class has been moved, but the tests were left in the old place.CallGraphConstructor
are based on the downloading functionality and download actual packages on every build, this is not acceptable. I propose two extensions 1) downloads should be cached in a configurable folder, which should also reduce the network footprint of the FASTEN pipeline. 2) The download logic inMavenCoordinate
should be refactored such that it can be mocked for theCallGraphConstructorTest
to avoid a download and make the test faster.Do we have any volunteer that wants to clean up this class?
The text was updated successfully, but these errors were encountered: